eth/api_backend: return error code for PoS tag requests before merge #28309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
requested review from
holiman,
karalabe and
rjl493456442
as code owners
|
I'd vote against this PR and change / hive test. The RPC is not specced to return error codes. Adding them ad-hoc will lead to a giant mess. We should either have a complete spec and do everything at once properly, or not touch it. Just adding one here because someone somewhere wanted it doesn't make sense. |
|
Agreed. To be clear though, it is in the spec: https://github.com/ethereum/execution-apis/blob/584905270d8ad665718058060267061ecfd79ca5/src/schemas/block.yaml#L114 It is just the only instance of returning a specific error code. |
|
Computer says no 🤷 Sorry man |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a specific testcase in hive that verifies the error code of PoS tag requests ("safe" / "finalized") before the finalization of the merge. This PR fixes that test.
Personally, I think the test is a bit overzealous and should be happy so long as the request errors. This is the first specific error code we return in the
ethJSON-RPC as far as I know. My preference would be to close this PR and update Hive instead with this: ethereum/hive#874